gdm/authPrompt: Factorize the entry update code

Cleanup the code a bit to make future updates smaller

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3850>

diff --git a/js/gdm/authPrompt.js b/js/gdm/authPrompt.js
index d7e94000d8e8d963fe103bd3305c5f9b3c864427..b6fdb65e901a85bf9dc29bb434cd82e67b7fe84b 100644 (file)
--- a/js/gdm/authPrompt.js
+++ b/js/gdm/authPrompt.js
@@ -293,15 +293,22 @@ export const AuthPrompt = GObject.registerClass({
     }
 
     _updateEntry(secret) {
+        let newEntry, inactiveEntry;
+
         if (secret && this._entry !== this._passwordEntry) {
-            this._mainBox.replace_child(this._entry, this._passwordEntry);
-            this._entry = this._passwordEntry;
-            this._inactiveEntry = this._textEntry;
+            newEntry = this._passwordEntry;
+            inactiveEntry = this._textEntry;
         } else if (!secret && this._entry !== this._textEntry) {
-            this._mainBox.replace_child(this._entry, this._textEntry);
-            this._entry = this._textEntry;
-            this._inactiveEntry = this._passwordEntry;
+            newEntry = this._textEntry;
+            inactiveEntry = this._passwordEntry;
+        }
+
+        if (newEntry) {
+            this._mainBox.replace_child(this._entry, newEntry);
+            this._entry = newEntry;
+            this._inactiveEntry = inactiveEntry;
         }
+
         this._capsLockWarningLabel.visible = secret;
     }